From 8048ff5c1739fa4932f324d00215e4be6fb97f7b Mon Sep 17 00:00:00 2001 From: aissat Date: Fri, 13 May 2022 16:08:24 +0100 Subject: [PATCH] fixed code analyze issues --- analysis_options.yaml | 1 - bin/generate.dart | 7 ++++--- lib/src/easy_localization_app.dart | 1 + lib/src/easy_localization_controller.dart | 1 + packages/easy_logger/analysis_options.yaml | 2 +- packages/easy_logger/pubspec.yaml | 2 +- 6 files changed, 8 insertions(+), 6 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 82ca5bdd..e88416f8 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,3 +1,2 @@ #https://dart.dev/guides/language/analysis-options -#include: package:pedantic/analysis_options.yaml include: package:flutter_lints/flutter.yaml \ No newline at end of file diff --git a/bin/generate.dart b/bin/generate.dart index f66eac77..591d182d 100644 --- a/bin/generate.dart +++ b/bin/generate.dart @@ -1,5 +1,6 @@ import 'dart:async'; import 'dart:convert'; +import 'dart:developer'; import 'dart:io'; import 'package:args/args.dart'; @@ -30,7 +31,7 @@ bool _isHelpCommand(List args) { void _printHelperDisplay() { var parser = _generateArgParser(null); - print(parser.usage); + log(parser.usage); } GenerateOptions _generateOption(List args) { @@ -290,9 +291,9 @@ class CodegenLoader extends AssetLoader{ // } void printInfo(String info) { - print('\u001b[32measy localization: $info\u001b[0m'); + log('\u001b[32measy localization: $info\u001b[0m'); } void printError(String error) { - print('\u001b[31m[ERROR] easy localization: $error\u001b[0m'); + log('\u001b[31m[ERROR] easy localization: $error\u001b[0m'); } diff --git a/lib/src/easy_localization_app.dart b/lib/src/easy_localization_app.dart index 2c638f0d..e5c9ec8c 100644 --- a/lib/src/easy_localization_app.dart +++ b/lib/src/easy_localization_app.dart @@ -65,6 +65,7 @@ class EasyLocalization extends StatefulWidget { /// Class loader for localization files. /// You can use custom loaders from [Easy Localization Loader](https://github.com/aissat/easy_localization_loader) or create your own class. /// @Default value `const RootBundleAssetLoader()` + // ignore: prefer_typing_uninitialized_variables final assetLoader; /// Save locale in device storage. diff --git a/lib/src/easy_localization_controller.dart b/lib/src/easy_localization_controller.dart index 8fab134a..15d66ca9 100644 --- a/lib/src/easy_localization_controller.dart +++ b/lib/src/easy_localization_controller.dart @@ -14,6 +14,7 @@ class EasyLocalizationController extends ChangeNotifier { Locale? _fallbackLocale; final Function(FlutterError e) onLoadError; + // ignore: prefer_typing_uninitialized_variables final assetLoader; final String path; final bool useFallbackTranslations; diff --git a/packages/easy_logger/analysis_options.yaml b/packages/easy_logger/analysis_options.yaml index 86bd4221..14777566 100644 --- a/packages/easy_logger/analysis_options.yaml +++ b/packages/easy_logger/analysis_options.yaml @@ -1,5 +1,5 @@ #https://dart.dev/guides/language/analysis-options -include: package:pedantic/analysis_options.yaml +include: package:flutter_lints/flutter.yaml analyzer: strong-mode: diff --git a/packages/easy_logger/pubspec.yaml b/packages/easy_logger/pubspec.yaml index db995324..42cc609e 100644 --- a/packages/easy_logger/pubspec.yaml +++ b/packages/easy_logger/pubspec.yaml @@ -12,6 +12,6 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0-nullsafety.3 + flutter_lints: ^2.0.1 flutter: \ No newline at end of file