Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make sync optional crate feature rather than default. #66

Closed
ajrcarey opened this issue Feb 4, 2023 · 3 comments
Closed

Make sync optional crate feature rather than default. #66

ajrcarey opened this issue Feb 4, 2023 · 3 comments
Assignees
@ajrcarey

Comments

@ajrcarey
Copy link
Owner

ajrcarey commented Feb 4, 2023

Follow-on from #59. As part of that issue, the then-new sync crate feature was added to the list of default crate features. However, there are still situations where passing a Pdfium instance across threads results in a segmentation fault; clearly, sync is not safe in every situation.

Make the sync feature opt-in rather than default.
@ajrcarey ajrcarey self-assigned this Feb 4, 2023
@ajrcarey
Copy link
Owner Author

ajrcarey commented Feb 4, 2023

For instance, rewriting examples/thread_safe.rs to create a single Pdfium instance and then passing that instance across threads causes a segfault.

@ajrcarey ajrcarey reopened this Feb 4, 2023
@ajrcarey
Copy link
Owner Author

ajrcarey commented Feb 4, 2023

Removed sync feature from default features list in Cargo.toml. Updated README.md. Packaged for release as crate version 0.7.29.

@ajrcarey
Copy link
Owner Author

ajrcarey commented Feb 5, 2023 •
edited
Loading

Corrected typos in README.md. Published to crates.io as release 0.7.29.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ajrcarey ajrcarey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajrcarey