Submission creates lots of blank pages

[linjialiang]

[linjialiang]

@akonwi Submission creates lots of blank pages

[linjialiang]

@akonwi

[VAdamec]

Same here, latest Atom, latest plugins and OSX

[devgtorres]

same here

[zdxn]

Can confirm, getting 20-40 windows per commit now.

[linjialiang]

I'm ready to use vscode

[akonwi]

Sorry about this guys. I haven't had the time or energy to address issues lately.

@VAdamec in the issue you opened in the atom repo, you mentioned you've seen this happen with another package. Do you know which one?

I'm looking into this now. Perhaps as a stop-gap, you can disable the setting for git-plus to split into a new pane and see if that helps.

Can y'all provide some more information about the context where you see this happen? How many projects do you have in the window, list of installed packages which may have an impact, etc.?

Something else that could be very helpful is if you could disable all other community packages but git-plus and see if the behavior still happens. That might be an inconvenience but it could help narrow down the problem area quickly.

[zdxn]

It seems to be reflective of the number of 'changed' files almost as in git-plus is trying to open a new window for each file thats been altered in the commit, instead of just 1 window per commit.

[akonwi]

That's very bizarre. Nothing about the code to open a pane for commits has changed in 2 years.

@zdxn have you tried to reproduce this after disabling your other packages?

[zdxn]

Only packages i have are language packs, git-plus is the only external plugin i have that would affect this.

[zdxn]

I'll say this behaviour has been happening for almost 2 months.
It could have been a core Atom update that broke this. It did not break with a git-plus release.

[linjialiang]

I find git-plus is rarely used because atom's terminal plug-ins are more powerful

platformio-ide-terminal can replace: git_bash.exe

[linjialiang]

@akonwi it doesn't matter

Well, thank you very much, plug-in developer, for making atom even better!

[RenaKunisaki]

For me it's creating hundreds of panes, when only one file has changed, and they even reappear after holding Ctrl+W for a while to close them all (and Atom itself). I had to disable the package to prevent endless panes opening. Atom 1.31.2 on Arch AMD64.

[akonwi]

@zdxn that's very interesting and good to know.

This is so odd. I use atom beta and nightly to stay ahead of updates and hopefully catch issues like this in advance but this one has eluded me.

@RenaKunisaki did you see my suggestion earlier?

I'm looking into this now. Perhaps as a stop-gap, you can disable the setting for git-plus to split into a new pane and see if that helps.

Can you try that and let me know if that remedies the problem for now?

[linjialiang]

@akonwi There is no problem with using the latest version

Atom    : 1.32.1
Electron: 2.0.9
Chrome  : 61.0.3163.100
Node    : 8.9.3

Today, I will continue to check whether there is any previous situation!

[linjialiang]

@akonwi git plus: push can cause problems

The tags will not be displayed on the latest edition of "ont light" and "one dark" due to the unreasonable theme of this official update!

[linjialiang]

I found a problem :atom cannot handle the source code generated by the prompt message !

[akonwi]

So this is starting to seem more like an issue with atom. I'll inspect a bit and see if i can debug where the bug is in atom.

@linjialiang Those templates are for atom notifications and aren't being generated directly by git-plus. I don't think that's an actual problem though. they shouldn't affect your user experience and I see them with any notification that gets created

[RenaKunisaki]

@RenaKunisaki did you see my suggestion earlier?

I'm looking into this now. Perhaps as a stop-gap, you can disable the setting for git-plus to split into a new pane and see if that helps.

Can you try that and let me know if that remedies the problem for now?

That does fix it! Also, the problem doesn't happen on my laptop (Arch Intel X64), but it does take ~30 seconds to open the pane there.

[akonwi]

Ok, I'm glad that works for now. Interesting though that it takes significantly longer to open the pane on another machine though.

[RenaKunisaki]

Now that I think about it, the delay might be caused by wifi, since I'm using sshfs there.

[akonwi]

yea that's plausible