Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Pinned Tabs acting weird #20

Closed
alzedd opened this issue Dec 4, 2020 · 2 comments
Closed

Pinned Tabs acting weird #20

alzedd opened this issue Dec 4, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@alzedd
Copy link

alzedd commented Dec 4, 2020

So, a couple of things.

  • there is a line that strikes through pinned tabs
  • selected pinned tabs goes under the reserved row and all the way to the right

here are a couple of images for reference.
Schermata 2020-12-04 alle 12 14 24
Schermata 2020-12-04 alle 12 14 29

@akshat46
Copy link
Owner

akshat46 commented Dec 4, 2020

Yes the strike is a known bug that I thought I fixed already. Will take a look once I'm free.

How would you expect the pinned tab to work otherwise if not move all the way to the right? Intention behind moving it to right was so that they show up properly in the userChrome-hover sidebar but if there's any other way you think might be better then I'm open to ideas. Should probably add separate behavior for static sudebars.

@akshat46 akshat46 added bug Something isn't working enhancement New feature or request labels Dec 4, 2020
@alzedd
Copy link
Author

alzedd commented Dec 5, 2020

Sorry, came with a problen and didn't bother to suggest a solution.

You're right, you probably should separate the behaviours on static and hover sidebars.
On hover it could work like this, on static maybe it's better to just highlight the active tab and leave it with the others on the top of the sidebar.

@akshat46 akshat46 closed this as completed Feb 6, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants