Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add more detail on gromacs benzene dataset descr #1

Closed
dotsdl opened this issue Mar 24, 2017 · 4 comments
Closed

Add more detail on gromacs benzene dataset descr #1

dotsdl opened this issue Mar 24, 2017 · 4 comments

Comments

@dotsdl
Copy link
Member

dotsdl commented Mar 24, 2017

The descr.txt for the Gromacs benzene dataset is a bit of a stub, and could use more detail, such as on:

  • system size
  • alchemical pathway
  • temperature
  • and anything else important for usage

Even a little ASCII diagram showing the alchemical pathway would help.

@dotsdl
Copy link
Member Author

dotsdl commented Mar 24, 2017

@ianmkenney would you mind taking this on, since this is your dataset?

@dotsdl
Copy link
Member Author

dotsdl commented May 16, 2017

Addressed by 90b07dd.

@dotsdl dotsdl closed this as completed May 16, 2017
@dotsdl
Copy link
Member Author

dotsdl commented May 17, 2017

@ianmkenney can you please add the expected solvation free energy for benzene in water in units of kT, with a reference, to the DESCR? This would give us a "right answer" to directly compare to. Could even make this an attribute of the data Bunch, too.

@dotsdl dotsdl reopened this May 17, 2017
@orbeckst
Copy link
Member

We didn't include a "right" answer for the Amber data #5 either. Philosophically, that's also a problem because this will depend on the method that is used to calculate the "right" answer from the data. For the tests, this is the reference value and it should live in the test case. Whoever writes the test will determine what the correct reference value for the method and parameters is going to be.

I think it is enough to include an experimental value, if one is available, to get a sense where the computed value should come down.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants