-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feature request: add a integer lost packets number to the ResponseList object #82
Comments
Hello, and sorry for late reply.
We can then keep the current name |
changes are added, please review them. |
Thank you for the code, changes are finem but can you please write tests for them? |
tests are changed, please review them |
Implemented in Release 1.1.3, out now! Thanks for providing the code for this! |
Is your feature request related to a problem? Please describe.
problem: currently ResponseList contains packets_lost variable which contains float ratio of lost packets to all sent packets.
but we can not know how many exactly packets was lost.
Describe the solution you'd like
we may add an other variable to ResponseList object for this and patch "append" method to count the lost packets
Describe alternatives you've considered
we may use math operations to determine lost packets number from the existing data.
for example, if count was 10, and packets_lost is 0.3, we know that 3 packets was lost.
but float operations are not precise.
The text was updated successfully, but these errors were encountered: