Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

2.7.0 breaks websocket compatibility #196

Closed
shlomimatichin opened this issue Feb 2, 2024 · 2 comments
Closed

2.7.0 breaks websocket compatibility #196

shlomimatichin opened this issue Feb 2, 2024 · 2 comments

Comments

@shlomimatichin
Copy link

this patch: 62e546c
removed the "Hijack" method, which is required to be able to escalate http 1.1 connection to websocket.
after upgrading, we now get: "websocket: response does not implement http.Hijacker", some googling relevant links:
https://stackoverflow.com/questions/62980183/response-does-not-implement-http-hijacker
we are downgrading for now.
@alexedwards
Copy link
Owner

Dupe of #188

@alexedwards
Copy link
Owner

See response in #188 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexedwards @shlomimatichin