-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add data to 'latest' [GET] endpoint. #1912
Comments
Just a note:
I hate my co-workers who do this, creating duplicated and useless fields in my API responses thus making the response bigger just because they are too lazy to do formatting in the client app, and they always revert their PRs after I talk some sense into them 😬 |
This issue is being kept open as a reminder that backwards compatibility needs to remain for Homepage and Organizr dashboards. https://docs.speedtest-tracker.dev/api/latest-result So I won't be making changes to this route and the future api responses will be in bytes (what the CLI returns) and in bits. We're doing this for the Influxdb integration for consistency already. |
@sunnycloudy1337 - Honestly, I can't say I disagree with you there... on both points! Both are very valid, and I will not contest you at all. 👍🏼 The client I am working with is 'API Ninja' a plugin for the StreamDeck. I'll contact them to see if they can do a better job at the formatting they do for data. That said, it may well just be a UI\UX 'issue' on their part... its not the most intuitive. |
I'm using the same integration, once the API endpoints are stood up I'll look into either formatting options or if there is a way with API Ninja. |
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
With residential internet speeds getting better, I recently upgraded my 1GB internet to 2GB. As a result, my speed tests are in the 1900 - 2300 Mbps range, as opposed to 800-950Mbps. I have a Stream Deck displaying my speeds and this is documented here. However, given that my results (since the upgrade) now display more digits, this makes is very congested on the StreamDeck button, PLUS... with so many tools that are(frustratingly) implementing regex and number formatting in their own unique ways, it would be beneficial if there were 2 data points added to the API that return the data in a clean 'pre-formatted' manner, so I could query those fields instead. Essentially, showing the results in the same format the 'Results' grid currently does in the app.
Example output:
Note the suggested "download_gb" and "upload_gb" fields that round up\down to the 2nd decimal place. 😉
Additional context
Thanks for considering.
://mk
The text was updated successfully, but these errors were encountered: