Skip to content

Commit

Permalink
fix(specs): ingestion destinations and transformations (#3477)
Browse files Browse the repository at this point in the history
  • Loading branch information
shortcuts authored Aug 5, 2024
1 parent a4412f6 commit cdd673d
Show file tree
Hide file tree
Showing 7 changed files with 40 additions and 4 deletions.
5 changes: 5 additions & 0 deletions specs/ingestion/common/schemas/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ taskID:
description: Universally unique identifier (UUID) of a task.
example: 6c02aeb1-775e-418e-870b-1faccd4b2c0f

transformationIDs:
type: array
items:
$ref: '#/transformationID'

transformationID:
type: string
# format: uuid
Expand Down
6 changes: 6 additions & 0 deletions specs/ingestion/common/schemas/destination.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Destination:
$ref: './common.yml#/updatedAt'
authenticationID:
$ref: './common.yml#/authenticationID'
transformationIDs:
$ref: './common.yml#/transformationIDs'
required:
- destinationID
- type
Expand All @@ -37,6 +39,8 @@ DestinationCreate:
$ref: '#/DestinationInput'
authenticationID:
$ref: './common.yml#/authenticationID'
transformationIDs:
$ref: './common.yml#/transformationIDs'
required:
- type
- name
Expand Down Expand Up @@ -71,6 +75,8 @@ DestinationUpdate:
$ref: '#/DestinationInput'
authenticationID:
$ref: './common.yml#/authenticationID'
transformationIDs:
$ref: './common.yml#/transformationIDs'

DestinationUpdateResponse:
type: object
Expand Down
2 changes: 2 additions & 0 deletions specs/ingestion/paths/transformations/transformations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ get:
- deleteIndex
- editSettings
parameters:
- $ref: '../../common/parameters.yml#/itemsPerPage'
- $ref: '../../common/parameters.yml#/page'
- $ref: '../../common/parameters.yml#/sort'
- $ref: '../../common/parameters.yml#/order'
responses:
Expand Down
28 changes: 27 additions & 1 deletion tests/CTS/requests/ingestion/createDestination.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[
{
"testName": "createDestination",
"parameters": {
"type": "search",
"name": "destinationName",
Expand All @@ -21,5 +20,32 @@
"authenticationID": "6c02aeb1-775e-418e-870b-1faccd4b2c0f"
}
}
},
{
"testName": "with transformationIDs",
"parameters": {
"type": "search",
"name": "destinationName",
"input": {
"indexPrefix": "prefix_"
},
"transformationIDs": [
"6c02aeb1-775e-418e-870b-1faccd4b2c0f"
]
},
"request": {
"path": "/1/destinations",
"method": "POST",
"body": {
"type": "search",
"name": "destinationName",
"input": {
"indexPrefix": "prefix_"
},
"transformationIDs": [
"6c02aeb1-775e-418e-870b-1faccd4b2c0f"
]
}
}
}
]
1 change: 0 additions & 1 deletion tests/CTS/requests/ingestion/listRuns.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[
{
"testName": "getRuns",
"parameters": {},
"request": {
"path": "/1/runs",
Expand Down
1 change: 0 additions & 1 deletion tests/CTS/requests/ingestion/listSources.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[
{
"testName": "getSources",
"parameters": {},
"request": {
"path": "/1/sources",
Expand Down
1 change: 0 additions & 1 deletion tests/CTS/requests/ingestion/listTransformations.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[
{
"testName": "getTransformations",
"parameters": {},
"request": {
"path": "/1/transformations",
Expand Down

0 comments on commit cdd673d

Please # to comment.