-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Aria labels to hitsPerPage #6473
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 025ce1b:
|
Thanks! to finalise this we'd want to have this option in translations for React InstantSearch, slots for Vue InstantSearch and templates for InstantSearch.js |
Ok. Where are those defined? |
Quick follow up regarding the |
Summary
I was working on improving the accessibility of a project using Instantsearch and noticed that the hits per page widget has no aria label, so I've added it to all three flavors of instantsearch and updated relevant tests
Result
Here's a screenshot of my version with an Aria label present on the hits per page selector.