Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add an e2e test to ensure Go plugins' memory safety #598

Open
johnlanni opened this issue Oct 23, 2023 · 1 comment
Open

Add an e2e test to ensure Go plugins' memory safety #598

johnlanni opened this issue Oct 23, 2023 · 1 comment

Comments

@johnlanni
Copy link
Collaborator

johnlanni commented Oct 23, 2023

Why do you need it?

TinyGo's GC can cause memory leaks in some scenarios, so we changed the GC to https://github.com/wasilibs/nottinygc and solved the memory leak issue (wasilibs/nottinygc#31).

The nottinygc lib is still being iterated frequently and we need to track and test new versions in features. So we need to conduct end-to-end testing to ensure memory safety when upgrading dependencies.

How could it be?

We already have a simple code to detect memory leaks when allocating byte slices of a specific size . We should extend more types of memory allocation (with or without layout, etc.) and add e2e tests for them like other plugins:
https://github.com/alibaba/higress/blob/main/test/e2e/conformance/tests/go-wasm-transformer.go

@rinfx
Copy link
Collaborator

rinfx commented Oct 24, 2023

apply for this issue

@github-project-automation github-project-automation bot moved this to Todo in Higress Dec 14, 2023
@johnlanni johnlanni moved this from Todo to Done in Higress Dec 14, 2023
@johnlanni johnlanni moved this from Done to Todo in Higress Dec 14, 2023
@johnlanni johnlanni moved this from Todo to In Progress in Higress Dec 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants