Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

using Chain of Responsibility to refactor ConfigQueryRequestHandler and ConfigServletInner #11659

Closed
shiyiyue1102 opened this issue Jan 15, 2024 · 2 comments · Fixed by #12892

Comments

@shiyiyue1102
Copy link
Collaborator

shiyiyue1102 commented Jan 15, 2024

using Chain of Responsibility refactor ConfigQueryRequestHandler and ConfigServletInner, replacing current serval if-else statements.

Create ConfigQueryHandler and ConfigQueryHandlerChain,ConfigQueryHandlerChainBuilder.
To exact BetaConfigQueryHandler-beta ,TagConfigQueryHandler-tag,FormalConfigQueryHandler-formal .

ConfigQueryHandlerChainBuilder builder with Handler of ordered name [ beta,tag,formal], if any handler matches this request,handler the request and return , delivery to next handler if not match.

ConfigQueryHandlerChainBuilder may design as a SPI interface ,for extensibility

@shiyiyue1102 shiyiyue1102 changed the title using Chain of Responsibility to refactor query config logic using Chain of Responsibility to refactor ConfigQueryRequestHandler and ConfigServletInner Jan 15, 2024
@Bo-Qiu
Copy link
Contributor

Bo-Qiu commented Jan 16, 2024

I wanna take it over, please assign to me, thx.

@KiteSoar
Copy link
Contributor

@i will solve it@

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants