Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Export EdiTextProps interface #114

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

chrisdanek
Copy link
Contributor

EdiTextProps are no longer exported in the new version. Previously I was able to create a wrapper component on top of the EdiText, without redeclaring all of the fields.

With EdiTextProps exported, I can easily create a wrapper component on top of the EdiText, without redeclaring all of the fields.
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for react-editext ready!

Built with commit 8f67dca

https://deploy-preview-114--react-editext.netlify.app

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #114 (8f67dca) into master (f556189) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files           2        2           
  Lines         138      138           
  Branches       70       70           
=======================================
  Hits          135      135           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f556189...8f67dca. Read the comment docs.

@alioguzhan
Copy link
Owner

Ah, nice catch. Thanks for the PR. I will merge this and release a new version to NPM once all checks are passed. @chrisdanek

@alioguzhan
Copy link
Owner

@all-contributors please add @chrisdanek for bug fix

@allcontributors
Copy link
Contributor

@alioguzhan

I've put up a pull request to add @chrisdanek! 🎉

@alioguzhan alioguzhan merged commit 6f843db into alioguzhan:master May 12, 2021
@alioguzhan
Copy link
Owner

Hey @chrisdanek , v4.1.2 is released at npm. can you please test and verify? Thanks!

@chrisdanek chrisdanek deleted the patch-1 branch May 13, 2021 18:47
@chrisdanek
Copy link
Contributor Author

Works great, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants