-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow numpy versions greater than 1.19 #449
Comments
I am having the same issue. I cannot downgrade my numpy version due to other packages requiring newer functionality. |
I'll look into this. We broke sktime when we tried to do this before (see #423, #425, and sktime/sktime#828, and sktime/sktime#831 for more detail) and they are much bigger than us, so we pinned it to what it is now. Hopefully I can whip something up! |
@aaronreidsmith Thanks for looking into this! I see that #451 is passing all checks but hasn't been merged yet. Do you have an estimate of when it will be merged? |
@freddyaboulton I was waiting on @tgsmith61591's approval. It is merged, we'll get a release out with the change soon |
Thank you @aaronreidsmith and @tgsmith61591 ! |
This should be fixed in version 1.8.3 which went out today |
Thank you! |
Is your feature request related to a problem? Please describe.
pmdarima has a pin on numpy 1.19 version which forces uses to use 1.19 across their entire library/application even if they have other dependencies.
This is problematic because if a user's dependency has a pin on numpy>=1.20, then their package is broken.
We saw this in sktime, where numba introduced a lower bound on numpy>=1.20 numba/numba#7339 and we couldn't upgrade numpy because then pmdarima could not be install ed.
Thank you!
Describe the solution you'd like
pmdarima depends on numpy>=1.19 or at least allow both numpy 1.19, 1.20
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: