fix: when a pull request is already open, link to it #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
gr2m
reviewed
Dec 28, 2020
Comment on lines
+169
to
+174
| // Hard fail, but recoverable (not ideal for UX) | ||
| this.log.error(error) | ||
| throw new AllContributorBotError( | ||
| `A pull request is already open for the branch \`${branchName}\`.`, | ||
| ) | ||
| } |
There was a problem hiding this comment.
@jakebolam I know it's been a while, but do you by chance recall what this code was about? It's not tested, and the error message doesn't make sense to me
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.