Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

error.code deprecation #54

Closed
Berkmann18 opened this issue Jan 17, 2019 · 1 comment · Fixed by #55
Closed

error.code deprecation #54

Berkmann18 opened this issue Jan 17, 2019 · 1 comment · Fixed by #55
Labels
bug Something isn't working released

Comments

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 17, 2019 •
edited
Loading

Describe the bug
Since @octokit/request@2.1.0, deprecation warnings pops up so it would be ideal to update the relevant code snippet.

To Reproduce
Steps to reproduce the behaviour:

  1. yarn test or npm test
  2. Wait for the following test suites to finish: test/utils/getUserDetails.test.js, test/index-e2e.test.js
  3. Look out for console.warn outputs.

Expected behaviour
This shouldn't be happening

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

console.warn node_modules/@octokit/request/lib/http-error.js:15
`error.code` is deprecated, use `error.status`.
@Berkmann18 Berkmann18 added the bug Something isn't working label Jan 17, 2019
Berkmann18 added a commit to Berkmann18/all-contributors-bot that referenced this issue Jan 17, 2019
@Berkmann18
fix: changed error.code to error.status (#54)
166dab5 
Due to deprecation warnings, I changed the `code` attribute to `status`
to fix
[ac-bot#54](all-contributors#54).
@Berkmann18 Berkmann18 mentioned this issue Jan 17, 2019
Merged
jakebolam pushed a commit that referenced this issue Jan 19, 2019
@Berkmann18 @jakebolam
fix: changed error.code to error.status (#54) (#55)
e858124 
Due to deprecation warnings, I changed the `code` attribute to `status`
to fix
[ac-bot#54](#54).
@all-contributors-release-bot
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

JoinGitHub1234567890 added a commit to JoinGitHub1234567890/all-contributors-bot that referenced this issue Jul 11, 2024
@JoinGitHub1234567890 @jakebolam
fix: changed error.code to error.status (#54) (#55)
879d87b 
Due to deprecation warnings, I changed the `code` attribute to `status`
to fix
[ac-bot#54](all-contributors/app#54).
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed error.code to error.status (#54) Berkmann18/all-contributors-bot
2 participants
@Berkmann18 @all-contributors-release-bot