Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] Reexport Client from reqwest #712

Closed
MathieuDutSik opened this issue May 7, 2024 · 1 comment
Closed

[Feature] Reexport Client from reqwest #712

MathieuDutSik opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MathieuDutSik
Copy link

Component

provider, pubsub

Describe the feature you would like

If the feature reqwest is enabled then it uses the reqwest::Client. The problem is that the type Client is not reexported from alloy. Therefore this causes some collision with other rust crates that uses different versions of reqwest.
Reexporting the Client would address that problem.

Additional context

It is possible that other types need to be reexported.
I can provide PRs about that if that could help.
@MathieuDutSik MathieuDutSik added the enhancement New feature or request label May 7, 2024
@MathieuDutSik
Copy link
Author

The issue has been addressed by the PR #716.
Thank you for addressing the problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MathieuDutSik