Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect content width on summary list rows when not all rows have actions #2495

Closed
fofr opened this issue Jan 12, 2022 · 1 comment · Fixed by #2515
Closed

Incorrect content width on summary list rows when not all rows have actions #2495

fofr opened this issue Jan 12, 2022 · 1 comment · Fixed by #2515
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) summary list
Milestone

Comments

@fofr
Copy link
Contributor

fofr commented Jan 12, 2022

Description of the issue

When using the summary-list nunjucks macro, when some rows have actions and some do not, the width given to the values in the row becomes too thin. This is most notable when using long content.

If all rows have actions the content has the correct width.

This commit could be the culprit: 2935863

v3.14 v4.0 v4.0 with just one row
v3 14 0 v4 0 0 v4 0 0-no-other-rows
v4 If I add width 50% to the container
Screenshot 2022-01-12 at 16 05 13 Screenshot 2022-01-12 at 16 05 07

Design system examples

This bug is visible on the design system examples too (https://design-system.service.gov.uk/components/summary-list/#adding-actions-to-each-row) – look at the two contact details rows:

Screenshot 2022-01-12 at 16 18 57

Steps to reproduce the issue

See design system example

Actual vs expected behaviour

Expected content to remain the same width

Environment (where applicable)

  • Operating system: Mac
  • Browser: Chrome
  • Browser version: 96
  • GOV.UK Frontend Version: 4.0.0
@fofr fofr added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Jan 12, 2022
@vanitabarrett vanitabarrett added summary list and removed awaiting triage Needs triaging by team labels Jan 12, 2022
@vanitabarrett vanitabarrett added this to the [NEXT] milestone Jan 12, 2022
@36degrees
Copy link
Contributor

This seems to happen specifically if the first row does not have actions, at least in Chrome.

Setting width: 20% on .govuk-summary-list__row--no-actions:after seems to fix it – though we also probably only need the pseudo-element at all on tablet and above.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) summary list
Projects
Development

Successfully merging a pull request may close this issue.

4 participants