You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the feature you'd like
Currently, the readout error in noise model only can targets observables result types through ObservableCriteria. This issue proposes to add MeasurementCriteria for applying readout error to circuits without observables result types.
Describe alternatives you've considered
Simply add the readout noise to the end of the circuit. When there are observables, this implementation will add noise before the basis rotation gates, not truly at the end of the circuit.
The text was updated successfully, but these errors were encountered:
Would be happy to pick this up. It looks like the key thing will be defining a new MeasurementCriteria class that extends ResultTypeCriteria and implement the abstract result_type_matches method with signature,
For the ObservableCriteria, there is a defined ObservableResultType and several classes that extend this type. There are five result types that do not extend the ObservableResultType:
StateVector
DensityMatrix
AdjointGradient
Amplitude, and
Probability
Am I correct in understanding that we are defining MeasurementCriteria for those circuits which have these result types, but not any of the observable result types? If so, defining the new MeasurementCriteria class and implementing result_type_matches is straightforward, but I am not sure what additional work may be necessary from there. I am also not certain this is the exact issue we are concerned with.
I'd appreciate some clarification on the original issue and some feedback on whether the approach I have described makes sense. To me, it feels like there are some gaps that may require some larger refactorings.
Describe the feature you'd like
Currently, the readout error in noise model only can targets observables result types through
ObservableCriteria
. This issue proposes to addMeasurementCriteria
for applying readout error to circuits without observables result types.How would this feature be used? Please describe.
Describe alternatives you've considered
Simply add the readout noise to the end of the circuit. When there are observables, this implementation will add noise before the basis rotation gates, not truly at the end of the circuit.
The text was updated successfully, but these errors were encountered: