Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(eslint-plugin-jest): allow 27.x peer dep #113

Merged
merged 2 commits into from
Sep 5, 2022
Merged

fix(eslint-plugin-jest): allow 27.x peer dep #113

merged 2 commits into from
Sep 5, 2022

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Sep 5, 2022 •
edited
Loading

Description

Please make sure that the PR fulfills these requirements

  • I checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • Rule changes includes a comment to describe the reasoning behind the change.
  • PR contains a single rule change.

Motivation and Context

eslint-plugin-jest released a new major version, peer dep requirements preventing users from using 27.x.x

How Has This Been Tested?

updated dev dep to use 27.0.1 of eslint-plugin-jest, ran tests on node 14, 16 before reverting version bump as tests fail in node 12

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

@JAdshead JAdshead requested a review from a team as a code owner September 5, 2022 18:05
@JAdshead JAdshead enabled auto-merge (squash) September 5, 2022 18:13
@JAdshead JAdshead merged commit e8624b0 into main Sep 5, 2022
@JAdshead JAdshead deleted the fix/eslint-plugin-jest-peer-dep branch September 5, 2022 20:29
oneamexbot added a commit that referenced this pull request Sep 5, 2022
@oneamexbot
chore(release): 15.3.1 [skip ci]
737ed6a 
## [15.3.1](v15.3.0...v15.3.1) (2022-09-05)

### Bug Fixes

* **eslint-plugin-jest:** allow 27.x peer dep ([#113](#113)) ([e8624b0](e8624b0))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 15.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

@bishnubista bishnubista bishnubista approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JAdshead @oneamexbot @10xLaCroixDrinker @bishnubista