feat(eslint): disable function scoping #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
previously approved these changes
May 11, 2020
10xLaCroixDrinker
previously approved these changes
May 11, 2020
PixnBits
previously requested changes
May 11, 2020
index.js
Outdated
| @@ -116,6 +116,10 @@ module.exports = { | |||
| // regular expressions. | |||
| 'unicorn/no-unsafe-regex': 'error', | |||
|
|
|||
| // This is a common pattern in React, and has been proven to be a premature optimization | |||
There was a problem hiding this comment.
can you provide a link for the "proven" portion? the rule itself has two links to support it's claims on perf, it'd be good to provide a counterargument if/when this rule comes into discussion in the future 🙏
There was a problem hiding this comment.
maybe a warning would be sufficient? probably depends on the analysis?
There was a problem hiding this comment.
I can't seem to find much supporting evidence either way
|
This pull request is stale because it has been open 30 days with no activity. |
JAdshead
dismissed stale reviews from 10xLaCroixDrinker and themself
via
7bc944e
JAdshead
reviewed
Jun 30, 2020
JAdshead
reviewed
Jun 30, 2020
mtomcal
approved these changes
Jul 1, 2020
10xLaCroixDrinker
approved these changes
Jul 1, 2020
JAdshead
pushed a commit
that referenced
this pull request
Jul 14, 2020
JAdshead
pushed a commit
that referenced
this pull request
Jul 16, 2020
oneamexbot
added a commit
that referenced
this pull request
Jul 16, 2020
# [13.0.0](v12.2.0...v13.0.0) (2020-07-16) ### Bug Fixes * **eslint:** disable prevent abbreviations ([#33](#33)) ([6647bef](6647bef)) ### Features * **eslint:** configuration ([#30](#30)) ([6229d4a](6229d4a)) * **eslint:** disable function scoping ([#35](#35)) ([0a0c5bb](0a0c5bb)) * **eslint:** disable prefer default export ([#26](#26)) ([45b88d3](45b88d3)) * **eslint:** enable jest rules ([#29](#29)) ([846bbf7](846bbf7)) * **eslint:** react/jsx quality of life rules ([#24](#24)) ([facff92](facff92)) * **js:** additional js rules ([58df834](58df834)) * **prettier:** add ([#45](#45)) ([00cecaf](00cecaf)) * **unicorn:** update and seperate rules ([#43](#43)) ([940eb66](940eb66)) * **unicorn/consistent-function-scoping:** disable ([#42](#42)) ([54dd5a3](54dd5a3)) ### BREAKING CHANGES * **unicorn:** major update to unicorn * **js:** no-lonely-if errors * **js:** no-return-assign, errors * **js:** prefer-object-spread, errors * **js:** no-bitwise, errors
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common pattern in React. The source of the measurements used as the basis for this rule were found to have been taken in the development version of React and were disproven. However, the myth persists. The React team has stated that this optimization is not necessary.