This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix(externalRegistry): prevent undefined entries #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {string} externals.[externalName].semanticRange semantic range module will accept | ||
| * @param {string} externals.[externalName].integrity hash value of fallback external | ||
| */ | ||
| function setModulesRequiredExternals({ moduleName, externals = {} }) { |
There was a problem hiding this comment.
If externals are undefined, should we be setting anything at all?
There was a problem hiding this comment.
i thought the same, landed on if a moduleName is provided it would be expected to be entered into the registry. Im not 100% tied to this.
There was a problem hiding this comment.
But if no externals are being passed, then the module technically doesn't require any externals at that point in time
There was a problem hiding this comment.
which is why i think it could be empty.
Co-authored-by: Matthew Mallimo <matthew.c.mallimo@aexp.com>
JAdshead
commented
Aug 24, 2023
Matthew-Mallimo
approved these changes
Aug 24, 2023
bishnubista
approved these changes
Aug 24, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limits the chance of external registries from having
undefinedentriesAlso included JSdoc declarations for external registry
Motivation and Context
fixes bug when integrated with One App.
How Has This Been Tested?
unit tests, tested locally by installing in to one-app server and running one-apps integration test suite. integration tests failed before changes and succeed after.
Types of Changes
Checklist:
What is the Impact to Developers Using Holocron?