fix(moduleRoute): return promises

[JAdshead]

Description

Rejected promises were not being returned which meant that they would fail and cause the App to crash

Motivation and Context

americanexpress/one-app#213

How Has This Been Tested?

locally and unit tests

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (adding or updating documentation)
• Dependency update

Checklist:

• My change requires a change to the documentation and I have updated the documentation accordingly.
• My changes are in sync with the code style of this project.
• There aren't any other open Pull Requests for the same issue/update.
• These changes should be applied to a maintenance branch.
• This change requires cross browser checks.
• This change impacts caching for client browsers.
• This change adds additional environment variable requirements for Holocron users.
• I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?