Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove diff output files from previous runs #52

Closed
anescobar1991 opened this issue Feb 25, 2018 · 1 comment · Fixed by arxiv-vanity/engrafo#291
Closed

Remove diff output files from previous runs #52

anescobar1991 opened this issue Feb 25, 2018 · 1 comment · Fixed by arxiv-vanity/engrafo#291
Labels
enhancement

Comments

@anescobar1991
Copy link
Member

Diff output files from previous runs should be removed before each assertion.

That way the user is not confused when a test is passing but there is still a diff output file in the __diff_output__ directory for said test (from a previous run that was failing).
@anescobar1991
Copy link
Member Author

Closed with 5f974af (PRd and reviewed internally)

@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Merged
@dependencies dependencies bot mentioned this issue Mar 14, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump jest-image-snapshot from 2.3.0 to 2.4.0 arxiv-vanity/engrafo
1 participant
@anescobar1991