Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bluebird 3 is sending warnings to the console. #130

Closed
nicksrandall opened this issue Dec 2, 2015 · 6 comments
Closed

Bluebird 3 is sending warnings to the console. #130

nicksrandall opened this issue Dec 2, 2015 · 6 comments

Comments

@nicksrandall
Copy link

https://github.com/petkaantonov/bluebird/blob/master/docs/docs/new-in-bluebird-3.md#warnings

Bluebird says you have a "runaway" promise in the promise chain starting in line 19 in index.js file.

Warning: a promise was created in a  handler but was not returned from it
    at Compiler.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/html-webpack-plugin/index.js:19:13)
    at Compiler.next (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:69:14)
    at /Users/nicksrandall/Desktop/dawp-test/node_modules/html-webpack-plugin/index.js:68:9
From previous event:
    at Compiler.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/html-webpack-plugin/index.js:67:15)
    at Compiler.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:71:13)
    at Compiler.emitAssets (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compiler.js:226:7)
    at Watching.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compiler.js:54:18)
    at /Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compiler.js:403:12
    at Compiler.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:60:69)
    at Compiler.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compiler.js:400:9)
    at Compilation.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compilation.js:577:13)
    at Compilation.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compilation.js:572:10)
    at Compilation.next (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:67:11)
    at Compilation.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/ng-annotate-webpack-plugin/index.js:34:13)
    at Compilation.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:71:13)
    at Compilation.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compilation.js:567:9)
    at Compilation.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compilation.js:563:8)
    at Compilation.applyPluginsAsync (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.seal (/Users/nicksrandall/Desktop/dawp-test/node_modules/webpack/lib/Compilation.js:525:7)
@jantimon
Copy link
Owner

jantimon commented Dec 2, 2015

Well there is a catch block:
https://github.com/ampedandwired/html-webpack-plugin/blob/master/index.js#L54

Any idea how we could solve this?

@nicksrandall
Copy link
Author

Because it's just a warning and not actually causing any problems, we could just turn it off. See #131

@jantimon
Copy link
Owner

jantimon commented Dec 3, 2015

Would still be nice to understand the cause of the warning ;)

@nicksrandall
Copy link
Author

I believe that the finally method is supposed to return another promise and the callback that is being passed doesn't return anything. We could probably do something like:

.finally(function () {
  callback();
  return null;
});

I haven't tested that but I have a hunch that that is where the problem is.

jantimon added a commit that referenced this issue Jan 11, 2016
@jantimon
Copy link
Owner

Fixed with 7e4f83b

@lock
Copy link

lock bot commented Jun 1, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants