Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

assets.manifest causes "ERROR in undefined is not a function" #56

Closed
chiplay opened this issue Jun 10, 2015 · 3 comments
Closed

assets.manifest causes "ERROR in undefined is not a function" #56

chiplay opened this issue Jun 10, 2015 · 3 comments

Comments

@chiplay
Copy link
Contributor

chiplay commented Jun 10, 2015

On https://github.com/ampedandwired/html-webpack-plugin/blob/master/index.js#L305 there is a .test method called on the match, but it should be the other way around, with .test called on the regex:

if (/\smanifest\s*=/.test(match)) {
  return match;
}
@jantimon
Copy link
Owner

Oh.. Good point - looks like this has never been tested.
Do you have time to write a pull request?

@chiplay
Copy link
Contributor Author

chiplay commented Jun 10, 2015

@jantimon I didn't have time to write a full test case, but its a pretty simple fix and I've verified its working correctly for our build.

@lock
Copy link

lock bot commented Jun 1, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants