Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: make @babel/runtime production dependencies #461

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

kevinpagtakhan
Copy link
Contributor

Summary

In the past, a change was introduced that moved @babel/runtime as dev dependency. The said change was included in v5.3.1 and is in effect until latest v8.13.0.

As mentioned in @babel/runtime docs:

This is meant to be used as a runtime dependency along with the Babel plugin @babel/plugin-transform-runtime. Please check out the documentation in that package for usage.

This PR fixes #451

Testing

Using adz/amplitude-esbuild as playground, I was reproduce the issue in v8.13.0 and v5.3.1; but not with v5.3.0 and this PR as expected.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change? No

@kevinpagtakhan kevinpagtakhan self-assigned this Dec 1, 2021
@kevinpagtakhan kevinpagtakhan marked this pull request as ready for review December 1, 2021 19:39
@kevinpagtakhan kevinpagtakhan merged commit c03632c into main Dec 3, 2021
@kevinpagtakhan kevinpagtakhan deleted the AMP-45375-babel-runtime-prod-dep branch December 3, 2021 19:09
github-actions bot pushed a commit that referenced this pull request Dec 3, 2021
## [8.13.1](v8.13.0...v8.13.1) (2021-12-03)

### Bug Fixes

* make @babel/runtime production dependencies ([#461](#461)) ([c03632c](c03632c))
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 8.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESBuild fails without @babel/runtime
2 participants