Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Failing tests in ampproject/optimizer library #4798

Closed
schlessera opened this issue May 29, 2020 · 0 comments · Fixed by #4799
Closed

Failing tests in ampproject/optimizer library #4798

schlessera opened this issue May 29, 2020 · 0 comments · Fixed by #4799
Labels
Changelogged Whether the issue/PR has been added to release notes. Optimizer Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Perf Work stream for Metrics, Performance and Optimizer
Milestone
v2.0

Comments

@schlessera
Copy link
Collaborator

Bug Description

The tests in the ampproject/optimizer are currently failing due to the following recently merged PR in the ampproject/amp-toolbox package:

ampproject/amp-toolbox#763

Link to failing build: https://travis-ci.org/github/ampproject/amp-wp/builds/692440360

The failures are due to the ID generation not using the same prefix and indexing scheme.

Expected Behaviour

All tests against the spec files in ampproject/amp-toolbox should pass.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry
@schlessera schlessera added Optimizer Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels May 29, 2020
@schlessera schlessera mentioned this issue May 29, 2020
Merged
3 tasks
@schlessera schlessera self-assigned this May 29, 2020
@westonruter westonruter added this to the v1.6 milestone Jun 2, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 5, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Optimizer Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Fix failing Optimizer spec tests with ID generation ampproject/amp-wp
3 participants
@schlessera @westonruter @kmyram