-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
separate standalone amuse-units package #634
base: main
Are you sure you want to change the base?
Conversation
installing amuse-units and then amuse-framework seems to work for me, as does installing just amuse-units. |
ok, but I think amuse units component themselves need some work to remove e.g. the amuse exceptions etc |
I think the exceptions can be converted to normal exceptions, however there is also some support utilities used (late, memoization |
I'll check. For many of those I don't think I know what they do... |
i think late does what functools cached_property (introduced in 3.8) does and the memoization is lru_cache (3.3 or so) |
Ok. I'm not yet happy with a 3.8 dependency but 3.3 is certainly fine. |
memoization speeds up the unit module considerably, the late stuff I have never really seen what it adds though |
Ah, I see. I guess it should have been memorize :). I'll see if I can replace that. |
lru_cache is not a simple drop-in replacement unfortunately... needs a bit more work. |
here's a description of how lru_cache could work for methods... not sure I like this. https://stackoverflow.com/questions/33672412/python-functools-lru-cache-with-class-methods-release-object |
just copying the necessary bits is always an option... |
(ie just putting the late and memoization bits also in units) with a comment and view of replacing them with standard constructs... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
keep open |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
No description provided.