Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Title Bar Colors should take into consideration FluentTheme.CustomAccentColor #639

Open
Abdo-reda opened this issue Jan 13, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@Abdo-reda
Copy link

Is your feature request related to a problem? Please describe.
The Title Bar Colors (MinMaxClose Controls) Use the System Accent Color if its available and ignores the CustomAccentColor if its set. As a result, if the application depends and uses the CustomAccentColor then there is a color mismatch (the application is using a color that is different from the title bar controls colors).

Describe the solution you'd like
I think the Function that sets the title bar colors private void SetTitleBarColors() should prioritize and use the CustomAccentColor if found, if not found then it should fallback to the current behavior.

Describe alternatives you've considered
We could also introduce a variable or configuration whether the titlebar colors should depend on the custom accent color or not. This will give the option so that if some developers want the title bar colors to depend on the system color and ignore the CustomAccentColor.

Additional context

  • SetTitleBarColors
  • An image showing what it could look like (minimize button) vs current behaviour (max and close buttons).
    image
@Abdo-reda Abdo-reda added the enhancement New feature or request label Jan 13, 2025
@Abdo-reda
Copy link
Author

Abdo-reda commented Jan 13, 2025

Update: I just noticed that LoadCustomAccentColor is called to set the custom accent color, which then calls UpdateAccentColors which updates the resource dictionary { "SystemAccentColor", accent }. Maybe the LoadCustomAccentColor is called after the title bar colors have been set? I am not sure. In this case, this is more likely a bug than a feature request.

@timunie
Copy link
Contributor

timunie commented Jan 15, 2025

you may want to try creating a PR and see if it solves your issue. I'm not a maintainer here, but from the past I can say that often bug fixes are accepted.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants