Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not use deprecated add-path command #71

Closed
jonico opened this issue Nov 3, 2020 · 1 comment · Fixed by #72
Closed

Do not use deprecated add-path command #71

jonico opened this issue Nov 3, 2020 · 1 comment · Fixed by #72
Assignees
Labels
bug Something isn't working

Comments

@jonico
Copy link
Contributor

jonico commented Nov 3, 2020

As indicated in https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ - the set-env and add-path workflow commands will be removed very soon as they can be exploited as shown here.

It appears that scan-action is currently using the add-path command although it is not really clear which subsequent action steps would even use the updated path. If the path was actually needed in subsequent commands, there is a new, file system based way of passing info between steps as described here.

@alfredodeza
Copy link
Contributor

Thanks for noting this one @jonico. Would love a way to detect these programmatically so that we can catch them as they are found :(

I'll investigate and fix accordingly

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants