Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing support for path prefixes during import to Anchore API #315

Closed
luhring opened this issue Jan 29, 2021 · 1 comment · Fixed by #318
Closed

Missing support for path prefixes during import to Anchore API #315

luhring opened this issue Jan 29, 2021 · 1 comment · Fixed by #318
Assignees
Labels
bug Something isn't working

Comments

@luhring
Copy link
Contributor

luhring commented Jan 29, 2021

This means that Syft's import feature does not work with the standard way we deploy Enterprise via Helm, where the API paths should be prefixed with /v1/. For details on the chart config, see https://github.com/anchore/anchore-charts/blob/8ff7bc108290ce07a6f2d92db5aa1be11985dc23/stable/anchore-engine/templates/enterprise_ui_configmap.yaml#L20

We're finding that users are trying to specify path prefixes with the host parameter (e.g. -H on the CLI), such as https://mydeployment.example.com/v1.

At a minimum:

  1. We need a way to allow the user to specify path prefixes as they tell Syft where their deployment is located (we should not assume that the user's API is deployed at a root path for a hostname).
  2. We need to ensure users have a smooth interaction with Anchore Enterprise by default.
@luhring luhring added the bug Something isn't working label Jan 29, 2021
@zhill
Copy link
Member

zhill commented Jan 29, 2021

This is a combination of a specific ingress config (combined UI and API, which isn't required, you can use 2 ingresses), and Anchore's service path optimization that makes /v1/ optional by rewriting /v1/ as a prefix internally. The API definition itself is versioned with /v1 prefix for that version of the API.

But supporting arbitrary prefixes on the routes will help general compatibility with various ingress/routing options between the system and syft.

@luhring luhring self-assigned this Feb 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants