Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] While bibisco is running, F5 doesn't work anymore (NOT limited to bibsco) #374

Open
ZosoDerGoldene opened this issue Nov 7, 2024 · 3 comments

Comments

@ZosoDerGoldene
Copy link

ZosoDerGoldene commented Nov 7, 2024

I'm using bibisco 4.0.0-SE on Windows 11 Pro Build 22631.4317, both on my desktop with a Logitech K860 and on my Surface Pro 8, either with the Surface keyboard or a separate K860.
As soon as I start bibisco, the F5 stops working - system-wide, as far as I can tell. Explicitly tested with Firefox, Chrome, and Windows Explorer. As soon as I close bibisco, it starts working again.
While bibisco is running, the keypress/keyrelease events still seem to fire (e.g., on https://www.keyboardtester.com/tester.html), but it doesn't do anything (e.g., refresh).
I'm pretty sure this started with 4.0.0-SE.

@ZosoDerGoldene
Copy link
Author

ZosoDerGoldene commented Nov 7, 2024

Found the culprit, bibisco/app/index.js essentially disables F5 for everyone - hence the name globalShortcuts, I presume.
I would be willing to submit a fix, but I'm unsure what the intention is; disable refreshing on F5 within bibisco?

@ZosoDerGoldene
Copy link
Author

More information on the electron behaviour can be found here and here.

@ZosoDerGoldene ZosoDerGoldene changed the title [BUG] While bibisco is running, F5 doesn't work anywhere [BUG] While bibisco is running, F5 doesn't work anymore (NOT limited to bibsco) Nov 7, 2024
@ZosoDerGoldene
Copy link
Author

May I propose using electron-localshortcut instead? I know this is only a minor issue, but it caused me to spend hours trying to find out what was wrong with my keyboards/drivers/browsers/OS setup, and I guess it will for other like-minded individuals, too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant