Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] APP_LDFLAGS override LOCAL_LDFLAGS in ndk-build #908

Closed
DanAlbert opened this issue Feb 8, 2019 · 2 comments
Closed

[BUG] APP_LDFLAGS override LOCAL_LDFLAGS in ndk-build #908

DanAlbert opened this issue Feb 8, 2019 · 2 comments
Assignees
@DanAlbert
Labels
bug ndk-build
Milestone
r20

Comments

@DanAlbert
Copy link
Member

https://android.googlesource.com/platform/ndk/+/master/build/core/build-binary.mk#531

APP_LDFLAGS come before LOCAL_LDFLAGS, so modules cannot override application-wide settings.
@DanAlbert DanAlbert added this to the r20 milestone Feb 8, 2019
@DanAlbert DanAlbert self-assigned this Feb 8, 2019
@DanAlbert
Copy link
Member Author

https://android-review.googlesource.com/c/platform/ndk/+/936754 (need to cherry-pick to r20 after beta 2 ships)

disigma pushed a commit to wimal-build/ndk that referenced this issue Mar 29, 2019
@DanAlbert
Allow module ldflags to override app-wide flags.
b98bcb5 
Test: ./checkbuild.py && ./run_tests.py
Bug: android/ndk#908
Change-Id: I6becdcc67b3ca42e0f695f5af10e287eac56b68e
disigma pushed a commit to wimal-build/ndk that referenced this issue Apr 15, 2019
@DanAlbert
Allow module ldflags to override app-wide flags.
1b55600 
Test: ./checkbuild.py && ./run_tests.py
Bug: android/ndk#908
Change-Id: I6becdcc67b3ca42e0f695f5af10e287eac56b68e
@DanAlbert
Copy link
Member Author

https://android-review.googlesource.com/c/platform/ndk/+/943639

mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
@DanAlbert
Update git submodules
ffa8b2c 
* Update ndk from branch 'ndk-release-r20'
  to c1e17d5b2b797bed4b3a691050546ff2854ec864
  - Merge "Allow module ldflags to override app-wide flags." into ndk-release-r20
  - Allow module ldflags to override app-wide flags.
    
    Test: ./checkbuild.py && ./run_tests.py
    Bug: android/ndk#908
    Change-Id: I6becdcc67b3ca42e0f695f5af10e287eac56b68e
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@DanAlbert DanAlbert

Labels
bug ndk-build
Projects
None yet
Milestone
r20
Development

No branches or pull requests
1 participant
@DanAlbert