Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Question: What are your thoughts/plans on @Nullable @NotNullable annotations? #106

Closed
tir38 opened this issue Jul 23, 2019 · 2 comments
Closed

Comments

@tir38
Copy link
Contributor

tir38 commented Jul 23, 2019

I'm going to fix a potential NPE in the code base. I thought it would be helpful to annotate the potentially-null-variable as @Nullable. I see you don't do this anywhere yet. Do you have any plans to do this? Did you explicitly not do this?

@andrzejchm
Copy link
Owner

back when the library was developed there was no preferred way of annotating arguments with @nullable nor @NotNull. I'm currently in the process of rewriting the library in Kotlin, so I believe that will fix the problem here

@tir38
Copy link
Contributor Author

tir38 commented Jul 23, 2019

Ok if you are in the middle of a re-write I might not open a PR to fix the issue.

Update: In fact when I went back to describe the issue I see that it was the same as #103. So I'm just going to grab the latest version.

@tir38 tir38 closed this as completed Jul 23, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants