Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Automatically add the first day of the month from angular locale #403

Open
ilya-git opened this issue Apr 20, 2016 · 5 comments
Open

Automatically add the first day of the month from angular locale #403

ilya-git opened this issue Apr 20, 2016 · 5 comments

Comments

@ilya-git
Copy link

Please see this issue: #282.

It is possible to add the first day of the month properly to the calendar. Now the days of week are loaded from angular locale, but not the first day of the week, which is available as well, so it should really be possible to do it automatically.

@ilya-git
Copy link
Author

Got unlucky "not found" id for the pull request, but hope it's gonna be implemented :)

@ilya-git ilya-git reopened this Apr 20, 2016
@peterver
Copy link
Contributor

you can set the first day of the week using the 'firstDay' option for your fullcalendar config object.

http://fullcalendar.io/docs/display/firstDay/

However, i couldn't find any option in fullCalendar myself on configuring the first day of the month ?

@ilya-git
Copy link
Author

Well, since that's an angular wrapper, then it should use the settings that are already available there. Day names e.g. are loaded from angular locale, and so should the first day of the week in my opinion. It can always be overridden with the setting you are referring to.

@peterver
Copy link
Contributor

peterver commented May 27, 2016

Not really, because the specific setting that you are referring to should not be prefilled based on locale. firstDay allows for overrides in cases where the first day of the week should be something different (uk), but there's a lot of international companies (even in the uk) that don't want this behavior (for consistency on an international level).

I do agree in a sense that if angular has already determined specific datasets ( such as locale ), that ui-calendar should use these to ease the configuration a bit. I might look into this :].

@ilya-git
Copy link
Author

I am not asking to remove the property. It's logical that you want to override it, but getting the default value from angular locale instead of hardcoding makes sense to me :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants