Skip to content

Commit 4822b3b

Browse files
clydinangular-robot[bot]
authored andcommitted
fix(@angular-devkit/build-angular): keep esbuild server active until builder fully stops
Use the now working builder teardown functionality to ensure that the development server is properly closed when the builder is stopped.
1 parent 4887138 commit 4822b3b

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/angular_devkit/build_angular/BUILD.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@ LARGE_SPECS = {
340340
],
341341
},
342342
"browser-esbuild": {
343+
"shards": 10,
343344
"extra_deps": [
344345
"@npm//buffer",
345346
],

packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,14 @@ export async function* serveWithVite(
148148
yield { success: true, port: listeningAddress?.port } as unknown as DevServerBuilderOutput;
149149
}
150150

151-
await server?.close();
151+
if (server) {
152+
let deferred: () => void;
153+
context.addTeardown(async () => {
154+
await server?.close();
155+
deferred?.();
156+
});
157+
await new Promise<void>((resolve) => (deferred = resolve));
158+
}
152159
}
153160

154161
async function setupServer(

0 commit comments

Comments
 (0)