build: standardize usage of js_binary (#62860)

Remove usages of nodejs_binary and use a commonly defined js_binary macro

PR Close #62860

Author: josephperrott

adev/shared-docs/pipeline/_guides.bzl

@@ -29,8 +29,7 @@ def _generate_guides(ctx):
         # For each input file "xxx.md", we want to write an output file "xxx.html"
         html_outputs += [ctx.actions.declare_file("%s.html" % relative_basepath)]
 
-    # Define an action that runs the nodejs_binary executable. This is the main thing that this
-    # rule does. If mermaid blocks are enabled then a different executable is used.
+    # Define an action that runs the executable.
     if (ctx.attr.mermaid_blocks):
         ctx.actions.run(
             inputs = depset(ctx.files.srcs + ctx.files.data),

adev/shared-docs/pipeline/api-gen/extraction/extract_api_to_json.bzl

@@ -45,8 +45,7 @@ def _extract_api_to_json(ctx):
     # Pass the set of (optional) extra entries
     args.add_joined(ctx.files.extra_entries, join_with = ",")
 
-    # Define an action that runs the nodejs_binary executable. This is
-    # the main thing that this rule does.
+    # Define an action that runs the executable.
     ctx.actions.run(
         inputs = depset(ctx.files.srcs + ctx.files.extra_entries),
         executable = ctx.executable._extract_api_to_json,

adev/shared-docs/pipeline/api-gen/manifest/generate_api_manifest.bzl

@@ -15,8 +15,7 @@ def _generate_api_manifest(ctx):
     manifest = ctx.actions.declare_file("manifest.json")
     args.add(manifest.path)
 
-    # Define an action that runs the nodejs_binary executable. This is
-    # the main thing that this rule does.
+    # Define an action that runs the executable.
     ctx.actions.run(
         inputs = depset(ctx.files.srcs),
         executable = ctx.executable._generate_api_manifest,

adev/shared-docs/pipeline/api-gen/rendering/render_api_to_html.bzl

@@ -18,8 +18,7 @@ def _render_api_to_html(ctx):
     args.add(html_output_directory.path)
     outputs = [html_output_directory]
 
-    # Define an action that runs the nodejs_binary executable. This is
-    # the main thing that this rule does.
+    # Define an action that runs the executable.
     ctx.actions.run(
         inputs = depset(ctx.files.srcs),
         executable = ctx.executable._render_api_to_html,

contributing-docs/building-with-bazel.md

@@ -136,11 +136,6 @@ See subcommands that bazel executes (helpful for debugging):
 yarn bazel build //packages/core:package -s
 ```
 
-To debug nodejs_binary executable paths uncomment `find . -name rollup 1>&2` (~ line 96) in
-```sh
-open $(yarn -s bazel info output_base)/external/build_bazel_rules_nodejs/internal/node_launcher.sh
-```
-
 ## Stamping
 
 Bazel supports the ability to include non-hermetic information from the version control system in

integration/ng-modules-importability/index.bzl

@@ -1,5 +1,5 @@
-load("@aspect_rules_js//js:defs.bzl", "js_test")
 load("@bazel_skylib//rules:write_file.bzl", "write_file")
+load("//tools:defaults2.bzl", "js_test")
 
 def module_test(name, npm_packages, skipped_entry_points = [], additional_deps = [], **kwargs):
     write_file(

packages/common/BUILD.bazel

@@ -1,23 +1,14 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
 load("//packages/common/locales:index.bzl", "generate_base_currencies_file")
 load("//tools:defaults.bzl", "generate_api_docs")
 load("//tools:defaults2.bzl", "api_golden_test", "api_golden_test_npm_package", "ng_package", "ng_project", "npm_package")
 
 package(default_visibility = ["//visibility:public"])
 
 # This generates the `src/i18n/currencies.ts` file through the `generate-locales` tool. Since
-# the base currencies file is checked-in for Google3, we add a `generated_file_test` to ensure
-# the checked-in file is up-to-date. To disambiguate from the test, we use a more precise target
-# name here.
+# the base locale file is checked-in for Google3, it is additionally stored in a golden location.
 generate_base_currencies_file(
-    name = "base_currencies_file_generated",
-    output_file = "base_currencies_generated.ts",
-)
-
-generated_file_test(
     name = "base_currencies_file",
     src = "src/i18n/currencies.ts",
-    generated = ":base_currencies_file_generated",
 )
 
 ng_project(

packages/common/locales/BUILD.bazel

@@ -1,23 +1,14 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
 load("//packages/common/locales:index.bzl", "LOCALES", "generate_all_locale_files", "generate_closure_locale_file")
 load("//tools:defaults.bzl", "pkg_npm")
 load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
 # This generates the `closure-locale.ts` file through the `generate-locales` tool. Since
-# the `closure-locale.ts` file is checked-in for Google3, we add a `generated_file_test` to
-# ensure the checked-in file is up-to-date. To disambiguate from the test, we use a more
-# precise target name here.
+# the base locale file is checked-in for Google3, it is additionally stored in a golden location.
 generate_closure_locale_file(
-    name = "closure_locale_file_generated",
-    output_file = "closure_locale_generated.ts",
-)
-
-generated_file_test(
     name = "closure_locale_file",
     src = "closure-locale.ts",
-    generated = ":closure_locale_file_generated",
 )
 
 generate_all_locale_files(

packages/common/locales/generate-locales-tool/BUILD.bazel

@@ -14,9 +14,11 @@ ts_config(
 ts_project(
     name = "generate-locales-tool",
     srcs = glob(["*.ts"]),
+    # Disabled to remove doubling of runtime files as we are approaching the 70k limit when
+    # CLDR files are also included in the binary action.
+    enable_runtime_rnjs_interop = False,
     deps = [
         "//:node_modules/@types/cldrjs",
-        "//:node_modules/@types/node",
         "//:node_modules/cldr",
         "//:node_modules/cldrjs",
         "//:node_modules/tinyglobby",

packages/common/locales/generate-locales-tool/bin/BUILD.bazel

@@ -1,5 +1,4 @@
-load("//tools:defaults.bzl", "nodejs_binary")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults2.bzl", "js_binary", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -13,18 +12,24 @@ BIN_ENTRYPOINTS = [
 ts_project(
     name = "bin",
     srcs = glob(["*.ts"]),
+    # Disabled to remove doubling of runtime files as we are approaching the 70k limit when
+    # CLDR files are also included in the binary action.
+    enable_runtime_rnjs_interop = False,
     deps = [
-        "//:node_modules/@types/node",
         "//packages/common/locales/generate-locales-tool:generate-locales-tool_rjs",
     ],
 )
 
-[nodejs_binary(
+[js_binary(
     name = entrypoint,
     data = [
-        ":bin",
+        ":bin_rjs",
         "@cldr_json_data//:all_json",
         "@cldr_xml_data//:all_xml",
     ],
     entry_point = ":%s.js" % entrypoint,
+    no_copy_to_bin = [
+        "@cldr_xml_data//:all_xml",
+        "@cldr_json_data//:all_json",
+    ],
 ) for entrypoint in BIN_ENTRYPOINTS]