Skip to content

Fix for Typescript 4.5 inference breaks in the PromiseProxy #3144

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2022
Merged

Fix for Typescript 4.5 inference breaks in the PromiseProxy #3144

merged 3 commits into from
Feb 7, 2022

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Feb 7, 2022 •
edited
Loading

Typescript 4.5 changed how inference with extends works, A) don't use Function as a type as that's a foot gun B) create a ReturnTypeOrNever/ParametersOrNever utility types to handle the inference changes. #3090 #3088

@jamesdaniels jamesdaniels merged commit f61bc7d into master Feb 7, 2022
@jamesdaniels jamesdaniels deleted the typescript_4.5_fix branch February 7, 2022 21:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesdaniels