Skip to content

Angularfire v19 broken for the compat API #3594

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rosostolato opened this issue Dec 19, 2024 · 4 comments
Closed

Angularfire v19 broken for the compat API #3594

rosostolato opened this issue Dec 19, 2024 · 4 comments

Comments

@rosostolato
Copy link
Contributor

rosostolato commented Dec 19, 2024 •
edited
Loading

Looks like the inject(NgZone) added here on #3586 are causing these issues for compat:

Image
Image

Here are the lines in the repo:
https://github.com/angular/angularfire/blame/main/src/compat/firestore/firestore.ts#L200
https://github.com/angular/angularfire/blame/main/src/compat/firestore/firestore.ts#L230
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

This was referenced Dec 19, 2024
Open
Merged
@rosostolato
Copy link
Contributor Author

Pushed a PR proposing the fix.

@Flayxamax
Copy link

I'm having the same problem with the latest version, did u get the fix?

@rosostolato
Copy link
Contributor Author

I'm having the same problem with the latest version, did u get the fix?

I pushed a PR with possible fix here #3595

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jamesdaniels @google-oss-bot @rosostolato @Flayxamax