Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(drawer): missing elevation shadow #8387

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

crisbeto
Copy link
Member

Fixes the elevation box shadow not being applied to drawers.

Fixes #8386.

@crisbeto crisbeto requested a review from mmalerba as a code owner November 12, 2017 15:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 13, 2017
@mmalerba
Copy link
Contributor

fixes #6528

@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 18, 2017
@jelbourn
Copy link
Member

Caretaker note: potential screenshot diffs

Fixes the elevation box shadow not being applied to drawers.

Fixes angular#8386.
@jelbourn jelbourn merged commit b0756a2 into angular:master Nov 20, 2017
@nueko
Copy link

nueko commented Nov 29, 2017

Halo,
Iam using multiple themes and the elevation gone

<mat-toolbar color="primary" class="mat-elevation-z6"></mat-toolbar>

and fixed with adding z-index

<mat-toolbar color="primary" class="mat-elevation-z6" style="z-index: 6"></mat-toolbar>

is this pr fix that issue?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shadow missing in opened mat-sidenav
5 participants