-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(form-field): jumping underline in Edge and Firefox #8480
fix(form-field): jumping underline in Edge and Firefox #8480
Conversation
2d47cfd
to
7dc6027
Compare
* In Edge and Firefox the underline jumps due to the `transform: perspective`. Also due to the `transform` the underline is getting slightly taller which isn't aligning with the specs. * Improves rendering of the ripple underline by always setting the 2px height. Since the element only uses `1px` if there are form-field errors the height can be adjusted on errors instead of on every focus/blur. Fixes angular#8395
7dc6027
to
0db692c
Compare
Are those screenshots from the current Chrome version? For me everything looks fine from 33%. As said this seems to depend on the screen resolution and Chrome's pixel rendering. |
Linux, Chrome 62.0.3202.94, 2560x1600 |
Hmm. Not sure about that. I don't think there is a reasonable fix for such zooming levels. What do you think? @mmalerba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, standard zoom level working on all browsers should take precedence.
Why not to create a chrome specific SCSS rule using media query? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
transform: perspective
. Also due to thetransform
the underline is getting slightly taller which isn't aligning with the specs.2px
.Note: The
perspective(1px)
might have fixed the zoom-out issue on some browsers, but itintroduces more issues than it helps (e.g. Firefox 57, Edge). Also the fix is not actually right. It just adds some subpixels to the
1px
underline and therefore makes it easier for the browser to render in some circumstances the zoomed-out element (conflicts with the Material Design specification of 1px).Fixes #8395