Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(input): allow color inputs in mat-form-field #8748

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(input): allow color inputs in mat-form-field #8748

merged 1 commit into from
Dec 13, 2017

Conversation

crisbeto
Copy link
Member

  • Allows users to put an input[type='color'] inside a form field.
  • Cleans out a few leftover floatPlaceholder usages.

Fixes #8686.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 30, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 1, 2017
@crisbeto
fix(input): allow color inputs in mat-form-field
4406d62 
* Allows users to put an `input[type='color']` inside a form field.
* Cleans out a few leftover `floatPlaceholder` usages.

Fixes angular#8686.
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 6, 2017
@andrewseguin andrewseguin merged commit 982982b into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
@crisbeto @andrewseguin
fix(input): allow color inputs in mat-form-field (angular#8748)
92d198b 
* Allows users to put an `input[type='color']` inside a form field.
* Cleans out a few leftover `floatPlaceholder` usages.

Fixes angular#8686.
@mmalerba mmalerba mentioned this pull request Mar 1, 2018
Closed
3 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input type color
4 participants
@crisbeto @googlebot @mmalerba @andrewseguin