Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

mat-accordion cause closed event to fire on already closed mat-expansion-panel #9098

Closed
wootapa opened this issue Dec 22, 2017 · 1 comment · Fixed by #9101
Closed

mat-accordion cause closed event to fire on already closed mat-expansion-panel #9098

wootapa opened this issue Dec 22, 2017 · 1 comment · Fixed by #9101
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@wootapa
Copy link

wootapa commented Dec 22, 2017 •
edited
Loading

Bug, feature request, or proposal:

Expanding a mat-expansion-panel inside an mat-accordion will cause its sibling mat-expansion-panel's to fire the closed event. This happens only on the first expansion.

What is the expected behavior?

Closed event should not fire on already closed mat-expansion-panel.

What is the current behavior?

On first expansion, the closed event is fired on all mat-expansion-panel's except the one you clicked.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-e4egwm

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 5.0.2 and Angular 5.00
@crisbeto crisbeto self-assigned this Dec 22, 2017
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Dec 22, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 22, 2017
@crisbeto
fix(accordion-item): emitting closed event while closed
afe9685 
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes angular#9098.
@crisbeto crisbeto mentioned this issue Dec 22, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 26, 2017
@crisbeto
fix(accordion-item): emitting closed event while closed
33623f3 
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes angular#9098.
jelbourn pushed a commit that referenced this issue Jan 4, 2018
@crisbeto @jelbourn
fix(expansion): accordion emitting closed event while closed (#9101)
92ded30 
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes #9098.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 8, 2018
@crisbeto @jelbourn
fix(expansion): accordion emitting closed event while closed (angular…
50161ae 
…#9101)

Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes angular#9098.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 9, 2018
@crisbeto @jelbourn
fix(expansion): accordion emitting closed event while closed (angular…
d61580b 
…#9101)

Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes angular#9098.
jelbourn pushed a commit that referenced this issue Jan 9, 2018
@crisbeto @jelbourn
fix(expansion): accordion emitting closed event while closed (#9101)
6ef0401 
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes #9098.
tinayuangao pushed a commit that referenced this issue Jan 10, 2018
@crisbeto @tinayuangao
fix(expansion): accordion emitting closed event while closed (#9101)
b286322 
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean.

Fixes #9098.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(accordion-item): emitting closed event while closed crisbeto/material2
2 participants
@wootapa @crisbeto