Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(menu): inconsistent side padding for nested menu items in RTL #9124

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

crisbeto
Copy link
Member

Fixes the menu items inside of a sub-menu having half as much padding as they're supposed to in RTL.

Fixes the menu items inside of a sub-menu having half as much padding as they're supposed to in RTL.
@crisbeto crisbeto requested a review from kara as a code owner December 25, 2017 11:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 25, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 12, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 12, 2018
@jelbourn jelbourn merged commit cc24c7c into angular:master Jan 23, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
…gular#9124)

Fixes the menu items inside of a sub-menu having half as much padding as they're supposed to in RTL.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants