Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(drawer): margins not being updated on direction changes #9161

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

Fixes the mat-drawer-container margins not being updated when its directionality has changed.

Fixes #9158.

Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
@crisbeto crisbeto requested a review from mmalerba as a code owner December 29, 2017 11:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Dec 31, 2017
@jelbourn jelbourn merged commit ff1c5f1 into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
…9161)

Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
…9161)

Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes #9158.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes #9158.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidenav: mat-sidenav-content margins not updated when dir changed
4 participants