Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(autocomplete): don't open panel for readonly inputs, even with keyboard #9227

Closed
gogakoreli opened this issue Jan 4, 2018 · 2 comments · Fixed by #9229
Closed

fix(autocomplete): don't open panel for readonly inputs, even with keyboard #9227

gogakoreli opened this issue Jan 4, 2018 · 2 comments · Fixed by #9229
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@gogakoreli
Copy link

Bug, feature request, or proposal:

When I disable input inside autocomplete I can still open the panel when input has focus and I click the arrow buttons on my keyboard.
#7271 this pull request only fixed this issue for input focus, panel doesn't open if I click on the input with the mouse or change focus with tab, but still opens with arrow keys.

What is the expected behavior?

Autocomplete panel shouldn't open when input is readonly, even with the keyboard

What is the current behavior?

Autocomplete panel opens when input is readonly using keyboard arrows

What are the steps to reproduce?

Autocomplete Stackblitz, in this example add readonly to the input inside autocomplete, then focus the input with mouse click and click on the keyboard down arrow key ( ↓ ).
@crisbeto crisbeto self-assigned this Jan 4, 2018
@julianobrasil
Copy link
Contributor

julianobrasil commented Jan 4, 2018 •
edited
Loading

Your stackblitz is using Material 5.0.0-rc3.

If you update it to Material 5.0.3, you'll noticed it doesn't happens anymore (the panel does not open neither for disabled nor for readonly inputs). It was fixed in PR #7271.

[EDIT]: sorry, I misread your issue. It is not covered by #7271

@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 4, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 4, 2018
@crisbeto
fix(autocomplete): prevent opening using arrow keys on readonly input
55bf5f7 
A while back we started blocking being able to open an autocomplete by focusing a readonly input, however that didn't cover opening using the keyboard shortcuts. These changes also prevent users from being able to open using the keyboard.

Fixes angular#9227.
@crisbeto crisbeto mentioned this issue Jan 4, 2018
Merged
jelbourn pushed a commit that referenced this issue Jan 21, 2018
@crisbeto @jelbourn
fix(autocomplete): prevent opening using arrow keys on readonly input
ce8061c 
A while back we started blocking being able to open an autocomplete by focusing a readonly input, however that didn't cover opening using the keyboard shortcuts. These changes also prevent users from being able to open using the keyboard.

Fixes #9227.
jelbourn pushed a commit that referenced this issue Jan 24, 2018
@crisbeto @jelbourn
fix(autocomplete): prevent opening using arrow keys on readonly input (…
9d152c0 
…#9229)

A while back we started blocking being able to open an autocomplete by focusing a readonly input, however that didn't cover opening using the keyboard shortcuts. These changes also prevent users from being able to open using the keyboard.

Fixes #9227.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
@crisbeto @jelbourn
fix(autocomplete): prevent opening using arrow keys on readonly input (…
f3b50b0 
…angular#9229)

A while back we started blocking being able to open an autocomplete by focusing a readonly input, however that didn't cover opening using the keyboard shortcuts. These changes also prevent users from being able to open using the keyboard.

Fixes angular#9227.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(autocomplete): prevent opening using arrow keys on readonly input crisbeto/material2
3 participants
@crisbeto @gogakoreli @julianobrasil