Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(select): support changing the value using left/right arrow keys while closed #9578

Merged

Conversation

crisbeto
Copy link
Member

Based on the native <select>, adds the ability for users to change the value on a closed select using the left/right arrow keys.

…hile closed

Based on the native `<select>`, adds the ability for users to change the value on a closed select using the left/right arrow keys.
@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Jan 24, 2018
@crisbeto crisbeto requested a review from kara as a code owner January 24, 2018 20:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 24, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 24, 2018
@jelbourn jelbourn merged commit 83b369e into angular:master Jan 25, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
…hile closed (angular#9578)

Based on the native `<select>`, adds the ability for users to change the value on a closed select using the left/right arrow keys.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants