Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow NaN, Infinity values for quantities #1289

Merged
merged 5 commits into from
Dec 30, 2023
Merged

Allow NaN, Infinity values for quantities #1289

merged 5 commits into from
Dec 30, 2023

Conversation

ebfortin
Copy link
Contributor

Add possibility to have double.NaN, double.NegativeInifinity and double.PositiveInifnity special values.

ebfortin added 2 commits July 15, 2023 15:06
@ebfortin
Remove Guard.EnsureValidNumber() calls.
ca3ba39 
Add possibility to have double.NaN, double.NegativeInifinity and double.PositiveInifnity special values.
@ebfortin
Remove all test cases related to NaN and Infinity for doubles.
55da776
@angularsen angularsen changed the base branch from master to release/v6 July 16, 2023 16:20
@angularsen
Copy link
Owner

Changed this to target v6 branch.

@angularsen angularsen added this to the vNext milestone Jul 16, 2023
angularsen
angularsen requested changes Jul 16, 2023
View reviewed changes
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to v6 branch, primarily to give it more time to mature and have some time for people to discuss the change before we make it official.

Would also like to keep the tests, but change them to test that nan/inf is allowed.

@angularsen angularsen added the pending-response Waiting for response from author of PR/issue. label Jul 16, 2023
@angularsen angularsen mentioned this pull request Aug 18, 2023
Closed
@angularsen angularsen changed the title Remove Guard.EnsureValidNumber() calls. Allow NaN, Infinity values for quantities Dec 30, 2023
@angularsen angularsen merged commit 99bf265 into angularsen:release/v6 Dec 30, 2023
1 check passed
@angularsen
Copy link
Owner

Lol, better late than never :D Nice!

@angularsen angularsen mentioned this pull request Jan 6, 2024
Open
20 tasks
@Muximize Muximize mentioned this pull request Feb 19, 2024
Merged
angularsen added a commit that referenced this pull request Feb 23, 2024
@Muximize @angularsen
Clean up some leftovers from Nan & Infinity checks (#1366)
b4316d7 
I think this was forgotten in #1289, removes 3k+ lines of comments that
are not true anymore.

---------

Co-authored-by: Andreas Gullberg Larsen <andreas.larsen84@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@angularsen angularsen angularsen requested changes

Assignees
No one assigned
Labels
breaking-change enhancement pending-response Waiting for response from author of PR/issue.
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.
2 participants
@ebfortin @angularsen