Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add units for Molality #1341

Merged

Conversation

peterjamesnugent
Copy link
Contributor

Closes #1340

Added conversion for Molality covering the following units:

  • MolePerKilogram
  • MolePerGram

@peterjamesnugent
Copy link
Contributor Author

peterjamesnugent commented Dec 22, 2023

@angularsen I have added the JSON, but running in to issues with the generate-code.bat

I have installed .NET 6.0 SDK (v6.0.320) - Windows x64 and running the .bat does not appear to do anything. Some code appears to pop up, but the terminal window closes almost instantly before I get a chance to read it.

Any ideas?

@angularsen
Copy link
Owner

@peterjamesnugent Open the bat file in a text editor, and you will see the command it tries to run.
I typically use Git for Windows bash shell and run generate-code.sh, but the two scripts basically do the same thing.

Try to run this manually and see what output you get. Should work from both Git Bash, Windows Powershell and Windows Commandline, whichever you have available.

# From UnitsNet repo directory
dotnet run --project CodeGen

@peterjamesnugent peterjamesnugent marked this pull request as ready for review December 22, 2023 13:11
@angularsen angularsen merged commit 33f6517 into angularsen:master Dec 22, 2023
1 check passed
@angularsen
Copy link
Owner

Looks perfect to me. Nicely done!

Nuget should be out shortly.

Release UnitsNet/5.40.0 · angularsen/UnitsNet

@peterjamesnugent peterjamesnugent deleted the #1340-AddUnitsForMolality branch January 2, 2024 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Molality units
2 participants